Add default value for signature algorithm #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Jan 16, 2025
| extensions: Certificate.Extensions {}, | ||
| issuerPrivateKey: privateKey | ||
| ) | ||
| } |
There was a problem hiding this comment.
I know it's a bit of a chore, but can we get equivalent tests for the CMS and CSR use-cases as well?
There was a problem hiding this comment.
It's done. One test is currently failing, but that should be addressed by #220.
Contrary to RSA and ECDSA that take a SHA digest of the message as their input, Ed25519 uses the original message when computing the signature. For this reason, no digest algorithm was previously defined for the Ed25519 signature algorithm. However CMS requires a digest algorithm to be present in the SignerInfo. Therefore creating a CMS signature using a Ed25519 private key would previously fail. Per RFC 8419 section 2.3, "When signing with Ed25519, the message digest algorithm MUST be SHA-512". AlgorithmIdentifier.init(digestAlgorithmFor:) has been updated accordingly. Signature operations have been updated to delegate the validation of the signature algorithm and the computation of the message digest (when relevant) to the underlying key.
baarde
force-pushed
the
default-signature-algorithm
branch
from
bfb155e to
6bbb4fb
Compare
Lukasa
approved these changes
Jan 21, 2025
|
Looks like there's a few format issues to fix up. |
|
OK, I've finally added |
|
Hah, sorry for that! The pain points of automation I suppose. |
|
Looks like we have some test failures here. |
Most of the time, the signature algorithm that should be used is dictated by the type of the private key. * Ed25519 keys support only one signature algorithm. * RFC 5753 section 8 recommends that "[the P-256 curve] be used with SHA-256; the P-384 curve be used with SHA-384; and the P-521 curve be used with SHA-512". * RSA keys support 4 signature algorithms. But most people use RSA with SHA-256 and nobody should use RSA with SHA-1 anymore. More over, Certificate.PrivateKey is opaque to the user, who may not know what type of private key they're using and what the appropriate signature algorithm is. For those reasons, we add convenience wrappers around methods with a signature algorithm to provide a reasonable default value.
|
That's the problem of putting my commits in independent PRs: CMS signature with Ed25519 doesn't work (yet). 😅 I've rebased on top of #220. This fixes the tests. |
auto-merge was automatically disabled
January 22, 2025 20:56
Head branch was pushed to by a user without write access
baarde
force-pushed
the
default-signature-algorithm
branch
from
849158f to
8f8ee07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time, the signature algorithm that should be used is dictated by the type of the private key.
More over, Certificate.PrivateKey is opaque to the user, who may not know what type of private key they're using and what the appropriate signature algorithm is.
For those reasons, we add convenience wrappers around methods with a signature algorithm to provide a reasonable default value.